Make Children property readonly

ita-social-projects · Feb 11, 2021 · 558704e · dmitrykiev · Feb 11, 2021 · 558704e
1 parent e4d3d4e
commit 558704e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/OutOfSchool/OutOfSchool.DataAccess/Models/Parent.cs b/OutOfSchool/OutOfSchool.DataAccess/Models/Parent.cs
@@ -14,7 +14,7 @@ public class Parent
         [DataType(DataType.Text)]
         [Required(ErrorMessage = "Last name is required")]
         public string LastName { get; set; }
-        public virtual ICollection<Child> Children { get; set; }
+        public virtual IReadOnlyCollection<Child> Children { get; set; }
 
         public Parent()
         {

diff --git a/OutOfSchool/OutOfSchool.WebApi/Controllers/ChildrenController.cs b/OutOfSchool/OutOfSchool.WebApi/Controllers/ChildrenController.cs
@@ -35,10 +35,9 @@ public ChildrenController(IChildService childService)
         [HttpGet]
         public ActionResult<IEnumerable<Child>> GetChildren()
         {
-            IEnumerable<ChildDTO> children;
             try
             {
-                children = this.childService.GetAll();
+                IEnumerable<ChildDTO> children = this.childService.GetAll();
                 return this.Ok(children);
             }
             catch (Exception ex)
@@ -55,10 +54,9 @@ public ActionResult<IEnumerable<Child>> GetChildren()
         [HttpGet("{id}")]
         public async Task<ActionResult<ChildDTO>> GetChildById(long id)
         {
-            ChildDTO childDTO;
             try
             {
-                childDTO = await this.childService.GetById(id).ConfigureAwait(false);
+                ChildDTO childDTO = await this.childService.GetById(id).ConfigureAwait(false);
                 return this.Ok(childDTO);
             }
             catch (ArgumentException ex)
@@ -81,10 +79,9 @@ public async Task<ActionResult<Child>> CreateChild(ChildDTO childDTO)
                 return this.BadRequest(this.ModelState);
             }
 
-            ChildDTO child;
             try
             {
-                child = await this.childService.Create(childDTO).ConfigureAwait(false);
+                ChildDTO child = await this.childService.Create(childDTO).ConfigureAwait(false);
                 return this.CreatedAtAction(
                     nameof(this.GetChildren),
                     new { id = child.Id },