Code Smells fix

ita-social-projects · Aug 15, 2022 · 9dd8983 · 9dd8983
1 parent 64ab639
commit 9dd8983
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/OutOfSchool/OutOfSchool.WebApi/Controllers/V1/MinistryAdminController.cs b/OutOfSchool/OutOfSchool.WebApi/Controllers/V1/MinistryAdminController.cs
@@ -65,7 +65,7 @@ public async Task<IActionResult> Profile()
     /// </summary>
     /// <param name="filter">Entity that represents searching parameters.</param>
     /// <returns><see cref="SearchResult{MinistryAdminDto}"/>, or no content.</returns>
-    [HasPermission(Permissions.MinistryAdmins)]
+    [HasPermission(Permissions.SystemManagement)]
     [HttpGet]
     [ProducesResponseType(StatusCodes.Status200OK, Type = typeof(SearchResult<MinistryAdminDto>))]
     [ProducesResponseType(StatusCodes.Status204NoContent)]

diff --git a/OutOfSchool/OutOfSchool.WebApi/Services/MinistryAdminService.cs b/OutOfSchool/OutOfSchool.WebApi/Services/MinistryAdminService.cs
@@ -102,7 +102,7 @@ public async Task<SearchResult<MinistryAdminDto>> GetByFilter(MinistryAdminFilte
 
         var sortExpression = new Dictionary<Expression<Func<InstitutionAdmin, object>>, SortDirection>
         {
-            { x => x.User.LastName , SortDirection.Ascending },
+            { x => x.User.LastName, SortDirection.Ascending },
         };
         var institutionAdmins = await institutionAdminRepository
             .Get(
@@ -260,7 +260,7 @@ public async Task<bool> IsProviderSubordinateAsync(string ministryAdminUserId, G
                       && x.Institution.RelatedProviders.Any(rp => rp.Id == providerId)).ConfigureAwait(false);
     }
 
-    private Expression<Func<InstitutionAdmin, bool>> PredicateBuild(MinistryAdminFilter filter)
+    private static Expression<Func<InstitutionAdmin, bool>> PredicateBuild(MinistryAdminFilter filter)
     {
         var predicate = PredicateBuilder.True<InstitutionAdmin>();
 
@@ -275,8 +275,7 @@ private Expression<Func<InstitutionAdmin, bool>> PredicateBuild(MinistryAdminFil
                          || x.User.LastName.StartsWith(word, StringComparison.InvariantCultureIgnoreCase)
                          || x.User.Email.StartsWith(word, StringComparison.InvariantCultureIgnoreCase)
                          || x.Institution.Title.StartsWith(word, StringComparison.InvariantCulture)
-                         || x.User.PhoneNumber.StartsWith(word, StringComparison.InvariantCultureIgnoreCase)
-                );
+                         || x.User.PhoneNumber.StartsWith(word, StringComparison.InvariantCultureIgnoreCase));
             }
 
             predicate = predicate.And(tempPredicate);

diff --git a/OutOfSchool/OutOfSchool.WebApi/Util/MappingProfile.cs b/OutOfSchool/OutOfSchool.WebApi/Util/MappingProfile.cs
@@ -296,7 +296,7 @@ public MappingProfile()
             .ForMember(dest => dest.PhoneNumber, opt => opt.MapFrom(src => src.User.PhoneNumber))
             .ForMember(dest => dest.Email, opt => opt.MapFrom(src => src.User.Email))
             .ForMember(dest => dest.AccountStatus, m => m.Ignore())
-            .ForMember(dest => dest.Gender, m => m.MapFrom((src => src.User.Gender)));
+            .ForMember(dest => dest.Gender, m => m.MapFrom(src => src.User.Gender));
 
         CreateMap<ProviderChangesLogRequest, ChangesLogFilter>()
             .ForMember(dest => dest.EntityType, opt => opt.Ignore())