Code Smells fixed

ita-social-projects · Jun 20, 2022 · adfce40 · adfce40
1 parent 159cdc4
commit adfce40
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 5 deletions.
diff --git a/OutOfSchool/OutOfSchool.WebApi.Tests/Controllers/ApplicationControllerTests.cs b/OutOfSchool/OutOfSchool.WebApi.Tests/Controllers/ApplicationControllerTests.cs
@@ -758,7 +758,7 @@ private List<WorkshopCard> FakeWorkshopCards()
             return eSlist;
         }
 
-        private WorkshopDescriptionItemDto FakeWorkshopDescriptionItem ()
+        private WorkshopDescriptionItemDto FakeWorkshopDescriptionItem()
         {
             var id = Guid.NewGuid();
             return new WorkshopDescriptionItemDto

diff --git a/OutOfSchool/OutOfSchool.WebApi.Tests/Controllers/WorkshopControllerTests.cs b/OutOfSchool/OutOfSchool.WebApi.Tests/Controllers/WorkshopControllerTests.cs
@@ -636,7 +636,7 @@ private List<WorkshopCard> FakeWorkshopCards()
             return eSlist;
         }
 
-        private WorkshopDescriptionItemDto FakeWorkshopDescriptionItem ()
+        private WorkshopDescriptionItemDto FakeWorkshopDescriptionItem()
         {
             var id = Guid.NewGuid();
             return new WorkshopDescriptionItemDto

diff --git a/OutOfSchool/OutOfSchool.WebApi.Tests/Services/Database/WorkshopServiceTests.cs b/OutOfSchool/OutOfSchool.WebApi.Tests/Services/Database/WorkshopServiceTests.cs
@@ -460,7 +460,6 @@ private Workshop WithWorkshop(Guid id)
                 Id = id,
                 Title = "ChangedTitle",
                 Phone = "1111111111",
-                //Description = "Desc1",
                 Price = 1000,
                 WithDisabilityOptions = true,
                 ProviderTitle = "ProviderTitle",

diff --git a/OutOfSchool/OutOfSchool.WebApi/Extensions/ElasticsearchMappingExtensions.cs b/OutOfSchool/OutOfSchool.WebApi/Extensions/ElasticsearchMappingExtensions.cs
@@ -11,7 +11,7 @@ namespace OutOfSchool.WebApi.Extensions
     // TODO: create a mapping profile instead of extensions
     public static class ElasticsearchMappingExtensions
     {
-        const char SEPARATOR = '¤';
+        private const char SEPARATOR = '¤';
 
         // From DTO to ES models
         public static WorkshopES ToESModel(this WorkshopDTO workshopDto)

diff --git a/...l/CustomValidation/CollectionValidator.cs → ...Validation/CollectionNotEmptyAttribute.cs b/...l/CustomValidation/CollectionValidator.cs → ...Validation/CollectionNotEmptyAttribute.cs
@@ -4,7 +4,7 @@
 namespace OutOfSchool.WebApi.Util.CustomValidation
 {
     [AttributeUsage(AttributeTargets.Property)]
-    public class CollectionNotEmpty : System.ComponentModel.DataAnnotations.ValidationAttribute
+    public class CollectionNotEmptyAttribute : System.ComponentModel.DataAnnotations.ValidationAttribute
     {
         public override bool IsValid(object value)
         {