Skip to content

Commit

Permalink
Fix code smell.
Browse files Browse the repository at this point in the history
  • Loading branch information
andriitsylia committed Jan 26, 2023
1 parent 7e6cdd0 commit c89f3e2
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions OutOfSchool/OutOfSchool.WebApi/Services/ChangesLogService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ public async Task<SearchResult<ProviderChangesLogDto>> GetProviderChangesLogAsyn
}
}

var (changesLog, count) = await GetChangesLogAsync(changeLogFilter).ConfigureAwait(false);
var changesLog = await GetChangesLogAsync(changeLogFilter).ConfigureAwait(false);

var providers = providerRepository.Get(where: predicate);

var query = changesLog
Expand Down Expand Up @@ -176,7 +177,8 @@ public async Task<SearchResult<ApplicationChangesLogDto>> GetApplicationChangesL
}
}

var (changesLog, count) = await GetChangesLogAsync(changeLogFilter).ConfigureAwait(false);
var changesLog = await GetChangesLogAsync(changeLogFilter).ConfigureAwait(false);

var applications = applicationRepository.Get(where: predicate);

var query = changesLog
Expand Down Expand Up @@ -269,18 +271,16 @@ public async Task<SearchResult<ProviderAdminChangesLogDto>> GetProviderAdminChan
};
}

private async Task<(IQueryable<ChangesLog>, int)> GetChangesLogAsync(ChangesLogFilter filter)
private async Task<IQueryable<ChangesLog>> GetChangesLogAsync(ChangesLogFilter filter)
{
ValidateFilter(filter);

var where = GetQueryFilter(filter);
var sortExpression = GetOrderParams();

var count = await changesLogRepository.Count(where).ConfigureAwait(false);

var query = changesLogRepository.Get(filter.From, filter.Size, string.Empty, where, sortExpression, true);

return (query, count);
return query;
}

private bool IsLoggingAllowed<TEntity>(out string[] trackedProperties)
Expand Down

0 comments on commit c89f3e2

Please sign in to comment.