ReSendEmailConfirmation has been added #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OutOfSchool/OutOfSchool.IdentityServer/Controllers/AccountController.cs
Outdated
Show resolved
Hide resolved
OutOfSchool/OutOfSchool.IdentityServer/Controllers/AccountController.cs
Outdated
Show resolved
Hide resolved
| ActionUrl = callBackUrl, | ||
| }; | ||
| var content = await renderer.GetHtmlPlainStringAsync(RazorTemplates.ConfirmEmail, userActionViewModel); | ||
| await emailSender.SendAsync(email, subject, content); |
There was a problem hiding this comment.
await emailSender.SendAsync(email, subject, content); - I see no check for unsuccessful send. Just curious - how fails are processed?
There was a problem hiding this comment.
I've rechecked: in the nested method SendAsync() there is try...catch
OutOfSchool/OutOfSchool.IdentityServer/Controllers/AccountController.cs
Outdated
Show resolved
Hide resolved
DmyMi
force-pushed
the
develop
branch
7 times, most recently
from
8fdf2a5 to
f6a4108
Compare
added 2 commits
April 28, 2023 15:42
valerabad
force-pushed
the
baditsa/resend-confirmation-email
branch
3 times, most recently
from
5924096 to
bbdc1c0
Compare
DmyMi
approved these changes
May 3, 2023
| var user = await userManager.FindByEmailAsync(User.Identity.Name); | ||
| var token = await userManager.GenerateEmailConfirmationTokenAsync(user); | ||
|
|
||
| await SendConfirmEmailProcess(user, RazorTemplates.ChangeEmail, new { userId = user.Id, token }); |
There was a problem hiding this comment.
maybe also add new email to passed data?
valerabad
force-pushed
the
baditsa/resend-confirmation-email
branch
from
bbdc1c0 to
4b68eec
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.