HotFix #123
Merged
HotFix #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YehorOstapchuk
requested review from
dmitrykiev,
DmyMi,
OlhaHoliak,
P0linux,
SergeyNovitsky,
v-ivanchuk and
VyacheslavDzhus
DmyMi
approved these changes
May 12, 2021
VyacheslavDzhus
approved these changes
May 12, 2021
P0linux
approved these changes
May 12, 2021
v-ivanchuk
approved these changes
May 12, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
P0linux
added a commit
that referenced
this pull request
May 20, 2021
* Snovitsky/identityserver localization (#115) * Added localization for the project IdentityServer * Added localization for the project IdentityServer * Added en and uk localization for Login and Register views (#120) * HotFix (#123) * fix * fix2 * Dzhus/unit tests for provider user (#122) * updated ProviderControllerTest * update ProviderServiceTest * added UserControllerTest * added UserServiceTest * fixed codesmells * Ostapchuk/Filtration (#128) * Add issue & pull request templates (#6) * Changing subcategory domain model * Changing category domain model * Adding subsubcategory domain model * Changing workshop domain model * Adding IWorkshop interface * Adding ISubcategoryRepositroy interface * Adding ISubsubcategoryRepository interface * Changing Workshop domain model 2 * Changing db context * Adding WorkshopRepository implementation * Adding SubcategoryRepository implementation * Adding SubsubcategoryRepository implementation * Changing SubcategoryDTO model * Adding SubsubcategoryDTO model * Changing CategoryDTO model * Changing WorkshopDTO model * Adding ICategoryService interface * Adding ISubcategoryService interface * Adding ISubsubcategoryService inteface * Adding WorkshopFilter model * Adding IWorkshopService interface * Adding predicate builder * Changing mapping * Adding SubcategoryService implementation * Adding SubsubcategoryService implementation * Changing workshopService implementation * Adding CategoryController * Adding SubcategoryController * Adding SubsubCategoryController * Changing ParentController * Adding CategoryService implementation * Adding CategoryService Tests * Adding SubcategoryService Tests * Adding SubsubcategoryServiceTests * Adding CategoryController Tests * Adding SubcategoryController Tests * Adding SubsubcategoryController Tests * Changing Startup * Fixing Mapping * fixing issues 2 * fixing issues 3 * fixing issues 3 * fixing issues 4 * Fixing issues * fixing smells * fixing issues * fixing issues * fixing issues * fix Co-authored-by: Dmytro Minochkin <[email protected]> * added Application entity and ApplicationStatus enum * added Applications collection to context * added ApplicationDTO * added mapping for Application * added ApplicationService * added ApplicationController * added Application services registration * fixed controller and entity * added migration for Application creating * added documentation for ApplicationController * added documentation for ApplicationService * added Application controller tests * added Application service tests and fixed Application controller tests * updated Application entity and migration * updated Application model * code cleanup * fixed code smells * updated ApplicationServiceTests to use UnitTestHelper * updated ApplicationService with extra validation * added tests for new validation in ApplicationService * fixed logging strings * Dzhus/user update (#125) * added property 'Role' * changed process of user registration * updated migration * fixed unit tests * renamed unit test * added new migration Co-authored-by: Sergey Novitsky <[email protected]> Co-authored-by: YehorOstapchuk <[email protected]> Co-authored-by: VyacheslavDzhus <[email protected]> Co-authored-by: Dmytro Minochkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.