Add notification for updating status of application to AcceptedForSelection #1480
Conversation
| if (applicationStatus == ApplicationStatus.Approved | ||
| || applicationStatus == ApplicationStatus.Rejected) | ||
| || applicationStatus == ApplicationStatus.Rejected | ||
| || applicationStatus == ApplicationStatus.AcceptedForSelection) |
There was a problem hiding this comment.
(Design) Please consider if this check could be extracted and reused as a helper method. Currently there are 2 other places where kind of same set of condition is checked - in ExecuteUpdateAsync() the if wrapping call to SendApplicationUpdateStatusEmail(), and in mentioned SendApplicationUpdateStatusEmail() the switch throwing "unsupported" ArgumentException when condition is not met. Here you've introduced the 3rd place.
If it's not the coincidence and it's expected that logic for all mentioned places should be the same - please make it technically the same and implemented in 1 place.
|
#1478