Ivanchuk/Child refactor #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-ivanchuk
requested review from
DmyMi,
OlhaHoliak,
P0linux,
SergeyNovitsky and
VyacheslavDzhus
OlhaHoliak
reviewed
Jun 24, 2021
| { | ||
| this.ValidateId(id, localizer); | ||
|
|
||
| var children = await service.GetAllByParent(id).ConfigureAwait(false); |
There was a problem hiding this comment.
I think we need to implement checkout whether ParentId belongs to User, who called method.
There was a problem hiding this comment.
Dear @OlhaHoliak,
Thank you a lot for your advice. I think it is a good idea, so I have implemented it.
Please review.
Thank you a lot.
|
|
||
| // Assert | ||
| Assert.That(result, Is.Not.Null); | ||
| Assert.AreEqual(200, result.StatusCode); |
There was a problem hiding this comment.
would be nice to use constants for 200 and 204 status code))
cold use this Assert.IsNotNull(result); for isnot null check))
There was a problem hiding this comment.
Dear @yfedo,
Thank you a lot for your advice. I have implemented them in the current PR.
Yuliya-Fedorenko
approved these changes
Jun 25, 2021
|
Kudos, SonarCloud Quality Gate passed! |
OlhaHoliak
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task #153