Fixed including workshopImages #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
SergeyNovitsky,
fkma13552,
toherberg,
DmyMi and
BHy4uk
|
Kudos, SonarCloud Quality Gate passed! |
DmyMi
approved these changes
Dec 22, 2021
DmyMi
added a commit
that referenced
this pull request
Dec 29, 2021
* Necheporenko/Added a rejection message after the status is changed to rejected * Necheporenko/Added a rejection message after the status is changed to rejected * Code review and small fixes * Change URL reading for determination if it is provider registration (#443) Co-authored-by: Sergii Novytskyi <[email protected]> * Fixed phone regex constant for RegisterViewModel (#449) * add dev container for UI team (#448) * add dev container for UI team * remove outdated MSSQL * Styles of Registration and SignIn pages have been fixed. (#450) * Added changes to status check and rejection messages * Added tests for workshopService. Create, GetById, GetbyProviderId, GetAll, Update is covered by tests (#451) * Changed the data output for feature flags (#452) * Changed the data output for feature flags * Applied changes to FeatureManagement * add parameter "providerRegistration" to the link on registration form (#460) Co-authored-by: Sergii Novytskyi <[email protected]> * Provicevko/ Upload/Get workshop images (#440) * Initial realization * Renamed main classes Added method for upload many images. Created Validate method for images. Changed names with "picture" -> "image". Added resources Added connecting files with errors Changed file collection, indexing Added logging for ImageService, ImageValidatorService. Added XML documentation Incuded ImageIds for getting Workshop by Id Fixed image width/height validation Added 413 description in WorkshopController/Create * Deleted migrations * reorder imports * Chenged getting, uploading images in ImageServcie * Fixed names. Changed Image<T> model, remove imageMetadata. Changed image services for returning externalImageIds without imageMetadata * Fixed p.1. Added MultipleKeyValueOperationResult. Changed UploadManyWorkshopImagesWithUpdatingEntityAsync(). * Added WorkshopController v2.0 Co-authored-by: Dmytro M <[email protected]> * add mongo config for CD (#461) * Added ApprovedTime of the application * Fix null reference while doing count validation (#464) * Added ApprovedTime of the application * add retries to MySql connection * Fixed model binding for nested types in multipart/form-data (#468) * Fixed RetryException (#469) * Novitsky/information about portal (#462) * Add models, controllers and services for "About Portal" information * Add models, controllers and services for "About Portal" information * Make a migration * fix update Co-authored-by: Sergii Novytskyi <[email protected]> * add image processing library (#470) * Fixed including workshopImages (#471) * Refactor/google logging (#472) * refactor logging * update min level * remove default logging config * add debug mode for elastic * add exception to error logs * add error results * fix log to string * add to string for operation error * test debug * fixed settings * update builder to full * add debug sink * Novitsky/backup for elasticsearch (#260) * Add first implementation with hard code for backup synchronization workshops * Add controller * Add create operation * Add first example of implementation * Use one query to database for one type of operation * delete migrations for correct rebase * rebase backup for elasticsearch onto develop * rename backuptracker to elasticsearchSynchronizationRecord * change logic for getting workshops * worked model for update * Implement bulk synchronization for create and update * delete migration * Add delete operation * Update controller * Add operation for delete all records * Add exception and logging * Add logs * Delete migration * Rebase on develop * fix mapping * remove migration * Add migration after rebase * uncomment authorization * Change models * Change migration according to new model * Change logic for tracking * Rewrite queries * fix converting sourceDto to ESModel * code refactoring * Add scheduler for synchronization * Fix scheduler * delete migration * fix after rebase * fix after rebase * fix issues * fix issues after rebase * restore previous implementation * Add repository for ElasticsearchSyncRecord * optimize elasticsearch synchronization * code refactoring * change mapper for ElasticsearchSyncRecord * Remove unnecessary mapping * Remove unnecessary mapping * delete migration before merge branches * add migration * configure mappings Co-authored-by: Sergii Novytskyi <[email protected]> * Added test for GetByFilter and Delete methods (#466) * Tatokhin/Unit tests + refactored controllers and services(Provider, InstitutionStatus, PermissionsForRole) (#447) * provider controller response fixed, tests for controller edited * used helper methods for assertion * controller delete method edited to catch exceptions, updated tests for it * provider controller and tests fixes * updated controller, addet test for getall action case, fixed test names * deleted unnecessary consts in tests * refactored provider service update action, fixed related files (controller, generator, tests) * refactored provider service, updated related controller actions, added requested changes for tests * added tests to examine provider controller update method, refactored controller logic for better communication * added tests to examine value stored in get all and get by id actions result * added methods to clone providers to assert collections by each object fields values * temporary method to clone provider in test helper * updated controller tests to use mapping extensions instead of additional method * generic test helpers, unit tests refactoring, minor changes in controllers * institutionstatus and permissionsforrole services tests improved * repaired failed tests, refactored code to return proper data - tupple instead anonymous type * new helper methods for faking data to use instead literals in tests * changed method to get expected result * created user fake user generator, updated provider service tests to avoid hardcoded user creation * added new features to generate objects and related values with randomizers instead of literals * refactoring and updates to use randomizers instead literals * replaced hard-coded objects in permissionsforroles controller tests with auto-generated entities * updated tests with randomizers * updated generator and used it for testing institution status controller and service * Necheporenko/Added a rejection message after the status is changed to rejected * Necheporenko/Added a rejection message after the status is changed to rejected * Code review and small fixes * Added changes to status check and rejection messages * Added ApprovedTime of the application Co-authored-by: Sergey Novitsky <[email protected]> Co-authored-by: Sergii Novytskyi <[email protected]> Co-authored-by: Dmytro Minochkin <[email protected]> Co-authored-by: Grygorii Makieiev <[email protected]> Co-authored-by: Viktor Tkachenko <[email protected]> Co-authored-by: provicevko <[email protected]> Co-authored-by: Olexandr Tatokhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.