Changes for getting information of InstitutionHierarchy #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alrom
commented
Jun 21, 2022
•
alrom
commented
- WorkshopDto, WorkshopCard, WorkshopES: Institution from InstitutionHierarchy was added to these models.
- InstitutionHierarchyController.GetParents: Adding current element to result by using new parameter "includeCurrentLevel".
- Fix InstitutionHierarchyServiceTests.
…od GetParents in InstitutionHierarchy service.
alrom
added
enhancement
ghost
approved these changes
Jun 21, 2022
DmyMi
approved these changes
Jun 21, 2022
DmyMi
approved these changes
Jun 21, 2022
| @@ -44,6 +44,10 @@ public class WorkshopES | |||
|
|
|||
| public string InstitutionHierarchy { get; set; } | |||
|
|
|||
| public Guid? InstitutionId { get; set; } | |||
There was a problem hiding this comment.
i did approve, but ID as a Guid field probably should have Keyword attribute. And do we need to have both id and name for elastic?
There was a problem hiding this comment.
- Ок.
- When we get the result of searching by ES we get the WorkshopES and convert it to WorkshopCard model for returning to front. I think title need to be for showing search result. If I clearly understand how it uses in forms on front )))
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.