Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetAll Endpoint for Achievement Types #755

Merged
merged 2 commits into from
Jul 13, 2022
Merged

GetAll Endpoint for Achievement Types #755

merged 2 commits into from
Jul 13, 2022

Conversation

maksgritchin
Copy link
Contributor

No description provided.

@maksgritchin maksgritchin requested a review from a team July 12, 2022 18:52
public AchievementTypeController(IAchievementTypeService service)
{
this.achievementTypeService = service;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add control at the null reference

this.localizer = localizer;
this.achievementTypeRepository = repository;
this.logger = logger;
this.mapper = mapper;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same, please add control at the null reference

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

2.5% 2.5% Coverage
0.0% 0.0% Duplication

@DmyMi DmyMi merged commit 46570f8 into develop Jul 13, 2022
@DmyMi DmyMi deleted the AchievementTypes branch July 13, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants