Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangesLogRepository: Fix NRE #757

Merged
merged 1 commit into from
Jul 14, 2022
Merged

ChangesLogRepository: Fix NRE #757

merged 1 commit into from
Jul 14, 2022

Conversation

i-rakityanskiy
Copy link
Contributor

After implementing soft delete, a NRE exception appeared in ChangesLogRepository. This is because a new IsDeleted column was added to the entities without a corresponding field in the C# classes. An attempt to access a missing PropertyInfo property in the IsDeleted property entry causes a NRE. To fix this Metadata.Name is used instead of Metadata.PropertyInfo.Name.

@i-rakityanskiy i-rakityanskiy requested a review from a team July 14, 2022 10:25
@i-rakityanskiy i-rakityanskiy self-assigned this Jul 14, 2022
@DmyMi DmyMi merged commit d797f1b into develop Jul 14, 2022
@DmyMi DmyMi deleted the iraki/changes-log-fix-nre branch July 14, 2022 10:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants