New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to see providers' chats for ministry admins #767

Merged

2 commits merged into develop from provicevko/ministry_admin_can_see_providers_chats

Jul 26, 2022

ghost commented Jul 24, 2022

For Ministry Admins:

Added ability to get chat rooms by Provider Id if Provider is a subordinate of Ministry Admin.
Added ability to see chat messages in allowed rooms (where Provider is a subordinate).
Added Operation handler in order to avoid duplicates.


          Added ability to see providers' chats for ministry admins

e5df1c3

ghost self-requested a review

July 24, 2022 22:18

VadymLevkovskyi reviewed

View reviewed changes

OutOfSchool/OutOfSchool.WebApi/Controllers/V1/ChatWorkshopController.cs Outdated Show resolved Hide resolved

VadymLevkovskyi approved these changes

View reviewed changes

Contributor

VadymLevkovskyi left a comment

From logic perspective - approved. From style/safe-coding perspective - see my other comment.


          Added null checks in the controller's constructor

70c942e

sonarqubecloud bot commented Jul 26, 2022

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

ghost merged commit 28aea18 into develop

ghost deleted the provicevko/ministry_admin_can_see_providers_chats branch

July 26, 2022 16:32

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet