rbiyovskiy/785 codeficator add ordering and city districts to the result of the search request #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RBiyovskiy
added
enhancement
valerabad
reviewed
Aug 3, 2022
OutOfSchool/OutOfSchool.WebApi/Models/Codeficator/AllAddressPartsDto.cs
Outdated
Show resolved
Hide resolved
| public string FullName | ||
| { | ||
| get | ||
| { | ||
| string addr = CityDistrict; | ||
| StringBuilder addr = new StringBuilder(); |
There was a problem hiding this comment.
Please set a clear name for the variable or remove if it's never used
valerabad
reviewed
Aug 3, 2022
valerabad
approved these changes
Aug 4, 2022
VadymLevkovskyi
approved these changes
Aug 5, 2022
RBiyovskiy
force-pushed
the
rbiyovskiy/785-codeficator-add-ordering-and-city-districts-to-the-result-of-the-search-request
branch
from
738b724 to
172e75f
Compare
|
SonarCloud Quality Gate failed. |
DmyMi
approved these changes
Aug 8, 2022
DmyMi
deleted the
rbiyovskiy/785-codeficator-add-ordering-and-city-districts-to-the-result-of-the-search-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see details in the description of the issue