Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add geocoding api #814

Merged
merged 12 commits into from
Aug 25, 2022
Merged

Add geocoding api #814

merged 12 commits into from
Aug 25, 2022

Conversation

DmyMi
Copy link
Contributor

@DmyMi DmyMi commented Aug 19, 2022 •
edited
Loading

  • Made webclient more generic and simplified some code.
  • Implemented a proxy for Geocoding API so that we don't expose API key
  • Implemented get nearest codeficator entry (representing a settlement) to certain coordinates

Need to add tests (in another pull request).

@DmyMi DmyMi requested a review from a team August 19, 2022 08:28
@DmyMi DmyMi marked this pull request as ready for review August 24, 2022 17:24
@DmyMi DmyMi requested a review from a team August 24, 2022 17:24
@DmyMi DmyMi force-pushed the dmin/geocoding_api branch from 785f9ad to 9664173 Compare August 24, 2022 17:44
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

5.5% 5.5% Coverage
8.6% 8.6% Duplication

@DmyMi DmyMi merged commit 33adeb5 into develop Aug 25, 2022
@DmyMi DmyMi deleted the dmin/geocoding_api branch August 25, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litvinets litvinets litvinets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmyMi @litvinets