Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of old code #837

Merged
merged 4 commits into from
Sep 2, 2022
Merged

Refactoring of old code #837

merged 4 commits into from
Sep 2, 2022

Conversation

DmyMi
Copy link
Contributor

@DmyMi DmyMi commented Sep 1, 2022

  • Removed City entity, as it is no longer used
  • Fixed Rider error in ChangeEmail.cshtml
  • Frontend only needs direction Ids, instead of full objects in WorkshopDTO. Removed unused field
  • Add full mapping for address to fully show all components on frontend

TODO: Add migration when approved

@DmyMi DmyMi requested a review from a team September 1, 2022 16:57
@DmyMi DmyMi merged commit c915cee into develop Sep 2, 2022
@DmyMi DmyMi deleted the dmin/refactoring branch September 2, 2022 10:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.8% 70.8% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valerabad valerabad valerabad approved these changes

@VadymLevkovskyi VadymLevkovskyi VadymLevkovskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DmyMi @valerabad @VadymLevkovskyi