Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination #408

Merged
merged 13 commits into from
Aug 6, 2021
Merged

Pagination #408

merged 13 commits into from
Aug 6, 2021

Conversation

litvinets
Copy link
Contributor

No description provided.

@litvinets litvinets requested a review from dmitryy90 August 5, 2021 16:26
font-style: normal;
font-weight: bold;
font-size: 13px;
line-height: 15px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check mobile view

@@ -13,6 +13,8 @@ export class Constants {
static readonly PHONE_LENGTH = 10;
static readonly PROVIDER_ENTITY_TYPE = 1;
static readonly WORKSHOP_ENTITY_TYPE = 2;
static readonly WORKSHOPS_PER_PAGE = 4;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12?

const currentPage = this.carouselPageList.find((page: PaginationElement) => page.element === this.currentPage.element);

let isForward: boolean = changes.currentPage.previousValue.element < changes.currentPage.currentValue.element;
if (isForward) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those two conditions could be meged

@litvinets litvinets merged commit 9b97c44 into develop Aug 6, 2021
@litvinets litvinets deleted the Pagination branch January 12, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants