Mobile view redesign#403/zubkov #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryy90
requested changes
Aug 30, 2021
src/app/app.component.html
Outdated
| <app-shell></app-shell> | ||
| <app-footer></app-footer> | ||
| <!-- Content of the page with opened sidebar --> | ||
| <mat-drawer-container> |
There was a problem hiding this comment.
extract it to component
src/app/app.component.ts
Outdated
| export class AppComponent implements OnInit, OnDestroy{ | ||
|
|
||
| readonly Languages: typeof Languages = Languages; | ||
| selectedLanguage: string = 'uk' |
There was a problem hiding this comment.
selected lang should be get from storage
There was a problem hiding this comment.
please let me know when you could clarify about this question
src/app/header/header.component.scss
Outdated
| flex-direction: row; | ||
| align-items: center; | ||
| position: fixed; | ||
| position: absolute; |
There was a problem hiding this comment.
why do you change position to absolute?
There was a problem hiding this comment.
returned, fixed and z-index as well
|
|
||
| @Selector() | ||
| static navigationPathsMobile(state: NavStateModel): Navigation[] { | ||
| const navigation = [...state.navigation] | ||
| return [navigation.pop()] | ||
| return [navigation.pop()] |
There was a problem hiding this comment.
please put semicolon where they are missed
There was a problem hiding this comment.
don't know why it showed up here, but it's not my changes
anyway, semicolon added
| SidenavToggle({patchState,getState}:StateContext<NavStateModel>): void { | ||
| const sidenavOpenState = getState().sidenavOpen | ||
| patchState({ |
…a-social-projects/OoS-Frontend into mobileViewRedesign#403/Zubkov
dmitryy90
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.