Feature/#414 #433
Merged
Feature/#414 #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryy90
requested changes
Aug 31, 2021
src/app/app.module.ts
Outdated
| @@ -52,7 +57,7 @@ import { NavigationState } from './shared/store/navigation.state'; | |||
| RegistrationModule, | |||
| ], | |||
| providers: [ | |||
|
|
|||
| { provide: LOCALE_ID, useValue: "uk" } | |||
There was a problem hiding this comment.
we use single quotes in ts
| * This method get applications by status | ||
| * @param status | ||
| */ | ||
| getApplicationsByStatus(status: number): Observable<Application[]> { |
| @@ -58,4 +79,44 @@ | |||
| &-hidden{ | |||
| visibility: hidden; | |||
| } | |||
| } | |||
| .person-text, .workshop-name-text{ | |||
| font-family: Innerspace; | |||
| MatIconModule | ||
| ], | ||
| providers: [ | ||
| { provide: LOCALE_ID, useValue: "uk" }, |
| @@ -80,7 +89,13 @@ export abstract class CabinetDataComponent implements OnInit, OnDestroy { | |||
| this.store.dispatch(new GetApplicationsByProviderId(this.provider.id)); | |||
| } | |||
|
|
|||
| getApplicationsByStatus(): void { | |||
| console.log(this.status); | |||
| <h5>{{ application.child.firstName }} {{ application.child.lastName }} {{ application.child.middleName }}</h5> | ||
| <p class="card-text">Дата народження: {{ application.child.dateOfBirth | date: 'shortDate'}}</p> | ||
| <p class="card-text">Дата подання заявки: {{ application.creationTime | date: 'shortDate' }}</p> | ||
| <div class="first-column" fxLayout='column' fxLayoutAlign='start start' > |
There was a problem hiding this comment.
it is a little bit confusing to see first-column class and id set to different elements. could you please check if we still need this?
| @@ -1,10 +1,15 @@ | |||
|
|
|||
| // .first-column{ | |||
There was a problem hiding this comment.
remove or add todo to commented code
dmitryy90
requested changes
Aug 31, 2021
| visibility: hidden; | ||
| } | ||
| } | ||
| .person-text, .workshop-name-text { | ||
| font-family: Innerspace; |
There was a problem hiding this comment.
please fix indentations
dmitryy90
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#414