Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nord color scheme #257

Merged
merged 3 commits into from
Nov 13, 2017
Merged

Add Nord color scheme #257

merged 3 commits into from
Nov 13, 2017

Conversation

arcticicestudio
Copy link
Contributor

@arcticicestudio arcticicestudio commented Nov 5, 2017

Added the Nord Vim lightline color scheme. It is also shipped with Nord Vim, but adding it to lightline itself might simplify the usage for some users. The comment header has been changed to adapt to the already included color schemes.

Mentioned in nordtheme/vim#68 by @lokesh-krishna


@itchyny
Copy link
Owner

itchyny commented Nov 5, 2017

I'm afraid I cannot merge this since I publish the plugin under MIT license.

@arcticicestudio
Copy link
Contributor Author

arcticicestudio commented Nov 5, 2017

I'll migrate my Nord project and all of it's official port projects to the MIT license as soon as possible. I've got some requests from other contributors and larger Open Source projects that would like to include my theme into their projects (mainly code editors and UI framework), but had conflicts with the license type.

I've started to use the Apache 2.0 license based on the fact that it has been used by almost all large projects, but in the last years it came out that the MIT license is much better when it comes to raise the Open Source movement without having to worry about all this crappy legal stuff 😄

I'll try to migrate all of my projects and update this PR until no later than the end of the next week, best even until this evening to finally check off this task from my list 🚀

Added the "Nord Vim" (1) color scheme. It is also shipped with Nord Vim,
but adding it to lightline itself simplifies the usage for many users.
Mentioned in nordtheme/vim#68 (2) by @lokesh-krishna

References:
  (1) https://github.com/arcticicestudio/nord-vim
  (2) nordtheme/vim#68

Signed-off-by: Arctic Ice Studio <[email protected]>
Nord and all port projects are migrating to the MIT license.

References:

* nordtheme/vim#70
* nordtheme/nord#55
@arcticicestudio
Copy link
Contributor Author

I've migrated the Nord Vim project to the MIT license and updated the PR. There were some merge conflicts so I've rebased on top of your master branch.

" Last Change: 2017/11/12 20:27:51
" =============================================================================

let s:nord_vim_version="0.6.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this unused variable.

@itchyny
Copy link
Owner

itchyny commented Nov 13, 2017

Thank you.

@itchyny itchyny merged commit e69081c into itchyny:master Nov 13, 2017
@arcticicestudio arcticicestudio deleted the feature/nord-color-scheme branch November 14, 2017 07:52
@fxn
Copy link

fxn commented Nov 18, 2017

The doc patch mentions "Nord", but as you can see in "material", that is supposed to be case-sensitive. Of course, if you configure "Nord" it won't work.

I think the more consistent solution is to keep the casing, and thus rename the file and the key within. Could volunteer a patch if you wish.

@itchyny
Copy link
Owner

itchyny commented Nov 18, 2017

Thanks, I fixed the help.

@arcticicestudio
Copy link
Contributor Author

Sorry about that, I've thought it was a list of included themes using the "human readable" name.
@fxn @itchyny Thanks or the fix.

@fxn
Copy link

fxn commented Nov 19, 2017

Thanks for this patch @arcticicestudio, I love Nord though I normally use my own theme. I have it now selected for vim-monochrome and the combination looks gorgeous.

YCbCr pushed a commit to YCbCr/lightline.vim that referenced this pull request May 26, 2019
YCbCr pushed a commit to YCbCr/lightline.vim that referenced this pull request May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants