Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement markdown in the prompt #258

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Implement markdown in the prompt #258

merged 2 commits into from
Nov 28, 2023

Conversation

msingleton
Copy link
Member

@msingleton msingleton commented Nov 21, 2023 •
edited
Loading

Screenshot 2023-11-21 at 11 00 39 AM

lankybutmacho
lankybutmacho reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@lankybutmacho lankybutmacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning for having them provide their own markdown renderer?

@msingleton
Copy link
Member Author

@lankybutmacho
Somewhat the same reason as why we do it for the secure storage and safe area, it allows users to choose which libraries they want to use rather than us dictating. Some of our customers have strict requirements (K)

Also, most users are unlikely to use markdown so kinda nice that it's optional and doesn't bloat by default

@msingleton msingleton merged commit 7f2bf75 into main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lankybutmacho lankybutmacho lankybutmacho approved these changes

@sambrown3 sambrown3 Awaiting requested review from sambrown3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msingleton @lankybutmacho