Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update option --token in cml-pr helppage #109

Closed
Crazy-Tony opened this issue Sep 17, 2021 · 2 comments · Fixed by #154
Closed

Update option --token in cml-pr helppage #109

Crazy-Tony opened this issue Sep 17, 2021 · 2 comments · Fixed by #154
Assignees
@casperdcl
Labels
documentation Markdown files

Comments

@Crazy-Tony
Copy link

The helppage of cml-pr describes the option --token as a personal access token, but project access tokens can also be used for that. So i recommend to update the helppage by adding information about project access tokens.
@casperdcl casperdcl added the documentation Markdown files label Sep 17, 2021
@casperdcl
Copy link
Contributor

The GitLab section under https://cml.dev/doc/self-hosted-runners#personal-access-token does indeed mention project access tokens. With #70 will hopefully make it clearer :)

@Crazy-Tony
Copy link
Author

Yes that's right. People like me, who are taking a look first into the helppage if something doesn't work as expected, the helppage seems quite misleading.

casperdcl added a commit that referenced this issue Nov 30, 2021
@casperdcl
ref: enumerate generic options
81e359b 
- fixes #109 --token=PAT description
@casperdcl casperdcl mentioned this issue Nov 30, 2021
Merged
@casperdcl casperdcl self-assigned this Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casperdcl casperdcl

Labels
documentation Markdown files
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref: document all options iterative/cml.dev
2 participants
@casperdcl @Crazy-Tony