ref/pr: add options & examples #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💅 Just a few things I would find useful (i.e. I had to check for the actual implementation to find out that any pathspec is supported as `git add` is being used)
casperdcl
suggested changes
Nov 29, 2021
Co-authored-by: Helio Machado <[email protected]> Co-authored-by: Casper da Costa-Luis <[email protected]>
Co-authored-by: Casper da Costa-Luis <[email protected]>
casperdcl
approved these changes
Nov 29, 2021
0x2b3bfa0
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Awesome! Thank you very much for the enhancements.
Still, I believe that it would be great to open two follow–up issues:
-
cml pr: Add--mergeoption. cml#823 -
Shell templates forflesh out the command reference (ref: full command reference #155, ref: document all options #154)
casperdcl
reviewed
Nov 29, 2021
| - name: Generate data | ||
| run: echo "Hello World" > output.txt | ||
| - name: Create and merge PR | ||
| run: gh pr merge --rebase $(cml pr "output.txt") |
There was a problem hiding this comment.
- PS would be nice to have a GL equivalent documented in another
<tab>in some follow-up PR (cml pr: Add GitLab example for automatic merge of pull requests #153)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💅 Just a few things I would find useful (i.e. I had to check for the actual implementation to find out that any pathspec is supported as
git addis being used)