Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cml ci to follow the cml <noun> <verb> naming convention #1141

Closed
Tracked by #1073
0x2b3bfa0 opened this issue Sep 7, 2022 · 5 comments
Closed
Tracked by #1073

Rename cml ci to follow the cml <noun> <verb> naming convention #1141

0x2b3bfa0 opened this issue Sep 7, 2022 · 5 comments
Assignees
Labels
cml-ci Subcommand discussion Waiting for team decision ui/ux User interface/experience

Comments

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Sep 7, 2022

The cml ci command hasn't been renamed as part of #1073 because we didn't agree on naming. See #1073 (comment) for more information.

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Sep 7, 2022

As per cml.dev/doc/ref/ci this command “prepares Git repository for CML operations” and, lacking a better alternative, my first proposal would be renaming it to cml repo prepare to fit its description.

@0x2b3bfa0
Copy link
Member Author

The current cml ci name was inspired by the npm ci command, which provides completely unrelated functionality.

@0x2b3bfa0 0x2b3bfa0 changed the title Rename cml ci to follow the cml <noun> <verb> Rename cml ci to follow the cml <noun> <verb> naming convention Sep 7, 2022
@dacbd
Copy link
Contributor

dacbd commented Nov 14, 2022

though I prefer the shorthand, this does already exist for us. Re-open if this requires more discussion.

@dacbd dacbd closed this as completed Nov 14, 2022
@casperdcl
Copy link
Contributor

casperdcl commented Nov 25, 2022

Can we please remove the misleading deprecation warning (it recommends using cml repo prepare)?

Fine by me to do any of the following instead:

  • cml ci
  • cml ci setup
  • cml ci <verb>

@casperdcl casperdcl reopened this Nov 25, 2022
@casperdcl
Copy link
Contributor

moved to #1287, fixed by #1288

@casperdcl casperdcl self-assigned this Feb 15, 2023
@casperdcl casperdcl added discussion Waiting for team decision ui/ux User interface/experience cml-ci Subcommand labels Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cml-ci Subcommand discussion Waiting for team decision ui/ux User interface/experience
Projects
None yet
Development

No branches or pull requests

3 participants