fix invalid deprecation warnings #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
casperdcl
commented
Dec 15, 2022
casperdcl
commented
- fixes invalid deprecation warnings #1287
casperdcl
added
p0-critical
0x2b3bfa0
previously approved these changes
Dec 15, 2022
casperdcl
force-pushed
the
fix-warnings
branch
from
f3b44fd to
d5f5b9b
Compare
casperdcl
force-pushed
the
fix-warnings
branch
from
d5f5b9b to
2c044d5
Compare
tasdomas
previously approved these changes
Dec 15, 2022
|
I'm definitely too tired to debug the failing test; @0x2b3bfa0 / @tasdomas feel free to take over :) |
0x2b3bfa0
approved these changes
Dec 15, 2022
dacbd
added a commit
that referenced
this pull request
Dec 20, 2022
* Revert "Revert "Allow running `cml pr create` without files (#1263)" (#1270)" This reverts commit 746ed2f. * Remove obscure defaults * Fix order of operations * Fix merge issues * Fix blunder * Turn errors into warnings * Update bin/cml/pr/create.js Co-authored-by: Domas Monkus <[email protected]> * Fix arguments blunder * npm run do_snapshots * debug * dont run git config --unset twice * dont run git config --unset twice * debug * debug * debug * debug * debug * Remove print-debugging code * fixup! Remove print-debugging code * Restore “not affected” check * Only move target branch when supplied with files * Remove last debug line * Debug telemetry * Fix blunder introduced with #1288 :old-man-yells-at-casper: * Remove debug message * Update snapshots * Fix flaky snapshot test * Update bin/cml/pr/create.js Co-authored-by: Casper da Costa-Luis <[email protected]> * Update src/cml.js Co-authored-by: Casper da Costa-Luis <[email protected]> * npm run do_snapshots Co-authored-by: Helio Machado <[email protected]> Co-authored-by: Domas Monkus <[email protected]> Co-authored-by: Casper da Costa-Luis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.