Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pr: --auto-merge fallback #907

Closed
casperdcl opened this issue Mar 9, 2022 · 0 comments · Fixed by #932
Closed

pr: --auto-merge fallback #907

casperdcl opened this issue Mar 9, 2022 · 0 comments · Fixed by #932
Assignees
@0x2b3bfa0
Labels
bug Something isn't working ci-github cml-pr Subcommand p1-important High priority ui/ux User interface/experience

Comments

@casperdcl
Copy link
Contributor

casperdcl commented Mar 9, 2022 •
edited
Loading

Follow-up to https://github.com/iterative/cml/pull/903/files#r817047473

cml pr --auto-merge may fail in GH free private repos. Convenient solution (rather than asking users to drop --auto-merge where it's unsupported):

if it fails, try direct merge
@casperdcl casperdcl mentioned this issue Mar 9, 2022
Merged
@casperdcl casperdcl added bug Something isn't working ci-github cml-pr Subcommand p2-nice-to-have Low priority ui/ux User interface/experience labels Mar 9, 2022
@0x2b3bfa0 0x2b3bfa0 mentioned this issue Mar 16, 2022
Merged
@0x2b3bfa0 0x2b3bfa0 mentioned this issue Mar 29, 2022
Open
@casperdcl casperdcl added p1-important High priority and removed p2-nice-to-have Low priority labels Mar 31, 2022
@0x2b3bfa0 0x2b3bfa0 linked a pull request Apr 3, 2022 that will close this issue
Add immediate auto-merge fallback #932
Merged
3 tasks
@0x2b3bfa0 0x2b3bfa0 mentioned this issue Apr 3, 2022
Merged
3 tasks
@0x2b3bfa0 0x2b3bfa0 self-assigned this Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
bug Something isn't working ci-github cml-pr Subcommand p1-important High priority ui/ux User interface/experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add immediate auto-merge fallback iterative/cml
2 participants
@casperdcl @0x2b3bfa0