CML workflow improvements #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperdcl
commented
Mar 29, 2022
Comment on lines
31
to
35
| git add --all | ||
| if [-z "$(git status --porcelain)"]; then | ||
| echo "::set-output name=push::false" | ||
| else | ||
| git commit -m "Results of the last experiment" -a | ||
| echo "::set-output name=push::true" | ||
| if [[ -n "$(git status --porcelain)" ]]; then | ||
| git commit -m "Results of the last experiment" | ||
| git push origin HEAD:${{ github.ref }} | ||
| fi |
There was a problem hiding this comment.
alternatively could (should?) use cml pr . here /CC @iterative/cml
There was a problem hiding this comment.
With iterative/cml#907, cml pr --auto-merge . would be an awesome alternative to all this git trickery.
There was a problem hiding this comment.
Update: now cml pr --squash . as per iterative/cml#823 and children
| id: commit | ||
| vl2png vega.json -s 1.5 | cml publish --md >> report.md | ||
| echo "## Metrics" >> report.md | ||
| dvc metrics show --md >> report.md |
There was a problem hiding this comment.
I assume dvc metrics show --md >> report.md works? Rather than the previous cat output/metrics.json >> report.md
There was a problem hiding this comment.
Probably? Assumptions are dangerous in CI/CD workflows; empyrical testing will dissipate our doubts.
casperdcl
commented
Mar 29, 2022
|
PS workflow failing for same reason as current |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a generated repo? @iesahin @tapadipti