Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create devcontainer.json #1082

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Create devcontainer.json #1082

merged 4 commits into from
Jun 29, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Jun 29, 2022 •
edited
Loading

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 29, 2022 18:47 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from a team June 29, 2022 18:47
@0x2b3bfa0 0x2b3bfa0 self-assigned this Jun 29, 2022
@0x2b3bfa0 0x2b3bfa0 added the enhancement New feature or request label Jun 29, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 29, 2022 18:50 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 29, 2022 18:51 Inactive
DavidGOrtega
DavidGOrtega suggested changes Jun 29, 2022
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 29, 2022 18:58 Inactive
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jun 29, 2022
Merged
@0x2b3bfa0 0x2b3bfa0 requested review from DavidGOrtega and dacbd June 29, 2022 19:09
@0x2b3bfa0 0x2b3bfa0 enabled auto-merge (squash) June 29, 2022 19:09
@0x2b3bfa0 0x2b3bfa0 merged commit 46286c6 into master Jun 29, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the devcontainer branch June 29, 2022 19:10
casperdcl
casperdcl reviewed Jul 4, 2022
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks:

  • maybe add DVC VSCode extension?
  • automatically do local npm install the checked out CML repo?
  • can the config file live under ./github/ to avoid root clutter?

@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jul 4, 2022
Merged
@0x2b3bfa0
Copy link
Member Author

maybe add DVC VSCode extension?

Makes more sense in the extension repository than in this one, to my mind. Once we have better (i.e. any) integration scenarios and we need it during development, it will be an awesome addition, though.

automatically do local npm install (after clone)?

can the config file live under ./github/ to avoid root clutter?

Moreover, it's not specific to GitHub Codespaces, but rather a Visual Studio Code feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl left review comments

@DavidGOrtega DavidGOrtega DavidGOrtega approved these changes

@dacbd dacbd Awaiting requested review from dacbd

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0x2b3bfa0 @DavidGOrtega @dacbd @casperdcl