Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .nvmrc file to support using the intended Node.js version #1257

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

magdapoppins
Copy link
Contributor

(Dev experience suggestion - feel free to close the pr if this doesn't seem like a good addition.)

As per https://cml.dev/doc/contributing/core, 16.x is the correct Node version to use for this repo - adding an .nvmrc file allows contributors that have nvm at hand to simply call nvm use to autoselect the projects intended Node version before npm install.

As per https://cml.dev/doc/contributing/core, Node 16.x is the correct version to use for this repo - adding an .nvmrc file allows contributors to simply call 'nvm use' to autoselect the projects intended Node version before 'npm install'
.nvmrc Outdated Show resolved Hide resolved
@dacbd dacbd temporarily deployed to external November 15, 2022 19:55 Inactive
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added newline to end of file for my OCD

@dacbd dacbd enabled auto-merge (squash) November 15, 2022 19:57
@dacbd dacbd added the technical-debt Refactoring, linting & tidying label Nov 15, 2022
@dacbd dacbd merged commit 65a200a into iterative:master Nov 15, 2022
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but, but, but...

"node": ">=16.0.0"

(my OCD hates dotfile root clutter)

@casperdcl casperdcl added the external-request You asked, we did label Nov 15, 2022
@dacbd
Copy link
Contributor

dacbd commented Nov 15, 2022

ㅋㅋㅋ we can revert if your OCD becomes too much ❤️

If it encourages another open source contributor my vote is +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-request You asked, we did technical-debt Refactoring, linting & tidying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants