fs: copyfile: don't show progress for files < 1G #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to create a progress bar overhead for anything that takes < 2sec to copy on a modern machine. Related iterative/dvc#9914
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
==========================================
- Coverage 65.10% 64.40% -0.70%
==========================================
Files 26 26
Lines 2000 2003 +3
Branches 316 317 +1
==========================================
- Hits 1302 1290 -12
- Misses 639 651 +12
- Partials 59 62 +3 ☔ View full report in Codecov by Sentry. |
|
Let's try this out, this is not making anything worse really and we can tweak further later on. |
5 tasks
efiop
added a commit
to efiop/dvc-objects
that referenced
this pull request
Dec 1, 2023
This again wastes a lot of time, as `set_size` might trigger a pbar refresh. Related iterative#229 Related iterative/dvc#9914
efiop
added a commit
that referenced
this pull request
Dec 1, 2023
This again wastes a lot of time, as `set_size` might trigger a pbar refresh. Related #229 Related iterative/dvc#9914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to create a progress bar overhead for anything that takes < 2sec to copy on a modern machine.
Related iterative/dvc#9914