Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glossary: tooltips break details sections #510

Closed
jorgeorpinel opened this issue Jul 31, 2019 · 9 comments · Fixed by #1359
Closed

glossary: tooltips break details sections #510

jorgeorpinel opened this issue Jul 31, 2019 · 9 comments · Fixed by #1359
Assignees
Labels
A: website Area: website p1-important Active priorities to deal within next sprints status: research Writing concrete steps for the issue 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jul 31, 2019

As a result of implementing #424, <abbr> tags now create glossary tooltips around certain terms in the docs.

However if one of these terms is placed inside a <details> section, the docs engine fails to create the expandable boxes (a pre-existing feature).


UPDATE: The example below is outdated but you get the idea hopefully.

For example open static/docs/user-guide/external-dependencies.md and change

### Expand to learn more about DVC internals

The resulting "import stage" DVC-file will contain something like this:

which looks

image

for

### Expand to learn more about DVC internals

The resulting <abbr>import stage</abbr> DVC-file will contain something like
this:

resulting in:

image

@jorgeorpinel

This comment has been minimized.

@jorgeorpinel jorgeorpinel added 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc labels Jul 31, 2019
@shcheklein shcheklein added the p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. label Jul 31, 2019
@algomaster99 algomaster99 self-assigned this Jul 31, 2019
@algomaster99
Copy link
Contributor

@jorgeorpinel This is happening since it only detects the abbr tags and just ignores the details tag. Seems weird to me. I'll have to check the inner functioning of HtmlRenderer.

@jorgeorpinel jorgeorpinel changed the title docs: glossary tooltips break details sections glossary: tooltips break details sections Aug 9, 2019
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Aug 13, 2019

When fixed:

  • We should add <abbr> to term "project" in the first <details> section of static/docs/get-started/configure.md, for now removed in ce3d940.
  • Re-add <abbr> in tags static/docs/get-started/add-files.md removed temporarily in ed4062e.
  • Undo also 6d642ef.
  • And d28add6

@jorgeorpinel jorgeorpinel added p1-important Active priorities to deal within next sprints and removed p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. labels Oct 19, 2019
@jorgeorpinel

This comment has been minimized.

@algomaster99
Copy link
Contributor

@jorgeorpinel I think this would require some changes in react-markdown itself. I found one issue which is relevant - remarkjs/react-markdown#302

@jorgeorpinel jorgeorpinel added the status: research Writing concrete steps for the issue label Oct 20, 2019
@shcheklein shcheklein added the A: docs Area: user documentation (gatsby-theme-iterative) label Nov 13, 2019
@jorgeorpinel jorgeorpinel removed the A: docs Area: user documentation (gatsby-theme-iterative) label Jan 20, 2020
@fabiosantoscode
Copy link
Contributor

I've opened this PR there which fixes this problem: remarkjs/react-markdown#386

@shcheklein
Copy link
Member

@fabiosantoscode awesome, thanks.

@rogermparent
Copy link
Contributor

rogermparent commented May 25, 2020

With #1334 (maybe before?), this seems to be fixed for me:
dvc-abbr-desktop
dvc-abbr-mobile

@jorgeorpinel The "When fixed" list may also need to update to our current docs content.

  • We should add <abbr> to term "project" in the first <details> section of static/docs/get-started/configure.md, for now removed in ce3d940.

Like this one, for example: we don't seem to have an glossary entry for "project"- did we change this term in the past? Oops, I forgot to port that term in another PR!

On a related note, I made #1357 because the test page threw a null error when I clicked a details on mobile without the change.

Anyway, once others confirm this is really fixed I think we'll want to draft up a new list of abbrs to add inside details and either add that to this issue or close this and make a new content-only one. Up to everyone's preference, really.

@rogermparent rogermparent self-assigned this May 25, 2020
@rogermparent
Copy link
Contributor

I'm working on fixing everything in the "When fixed" list, now that I realize it's current enough for me to figure it out and we aren't missing whole terms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website p1-important Active priorities to deal within next sprints status: research Writing concrete steps for the issue 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants