-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glossary: tooltips break details sections #510
Comments
This comment has been minimized.
This comment has been minimized.
@jorgeorpinel This is happening since it only detects the |
This comment has been minimized.
This comment has been minimized.
@jorgeorpinel I think this would require some changes in |
I've opened this PR there which fixes this problem: remarkjs/react-markdown#386 |
@fabiosantoscode awesome, thanks. |
With #1334 (maybe before?), this seems to be fixed for me: @jorgeorpinel The "When fixed" list may also need to update to our current docs content.
On a related note, I made #1357 because the test page threw a null error when I clicked a Anyway, once others confirm this is really fixed I think we'll want to draft up a new list of |
I'm working on fixing everything in the "When fixed" list, now that I realize it's current enough for me to figure it out and we aren't missing whole terms. |
As a result of implementing #424,
<abbr>
tags now create glossary tooltips around certain terms in the docs.However if one of these terms is placed inside a
<details>
section, the docs engine fails to create the expandable boxes (a pre-existing feature).UPDATE: The example below is outdated but you get the idea hopefully.
For example open
static/docs/user-guide/external-dependencies.md
and change### Expand to learn more about DVC internals The resulting "import stage" DVC-file will contain something like this:
which looks
for
resulting in:
The text was updated successfully, but these errors were encountered: