Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

term: don't mix quoted text (notes) with bold "Note!" remarks #848

Closed
jorgeorpinel opened this issue Dec 9, 2019 · 1 comment · Fixed by #846
Closed

term: don't mix quoted text (notes) with bold "Note!" remarks #848

jorgeorpinel opened this issue Dec 9, 2019 · 1 comment · Fixed by #846
Labels
A: docs Area: user documentation (gatsby-theme-iterative)

Comments

@jorgeorpinel
Copy link
Contributor

That's kind of contradictory. Notes in md quotes > are not very visible so they should be meant for side-notes that could be completely omitted without affecting the document – same function as parentheses in a paragraph, for example.

Bold notes with excalmation point (**Note!**) should not be in md quotes.
@jorgeorpinel jorgeorpinel changed the title Don't mix quoted text (notes) with bold "Note!" remarks term: don't mix quoted text (notes) with bold "Note!" remarks Dec 9, 2019
@jorgeorpinel jorgeorpinel mentioned this issue Dec 9, 2019
Merged
@jorgeorpinel
Copy link
Contributor Author

Context: #833 (review)

@jorgeorpinel jorgeorpinel mentioned this issue Dec 10, 2019
Merged
jorgeorpinel added a commit that referenced this issue Dec 10, 2019
@jorgeorpinel
term: remove some bold notes in quotes, add some emojis
c68f2fa 
for #848 and #855
jorgeorpinel added a commit that referenced this issue Dec 10, 2019
@jorgeorpinel
term: finish reviewing bold notes in docs, adds some more emojis
66d1e52 
to finish #848, and advance #855
@shcheklein shcheklein added the A: docs Area: user documentation (gatsby-theme-iterative) label Dec 10, 2019
@weekly-digest weekly-digest bot mentioned this issue Dec 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: docs Area: user documentation (gatsby-theme-iterative)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Regular doc updates (early Dec) iterative/dvc.org
2 participants
@jorgeorpinel @shcheklein