Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd ref: more updates on new dag command #1496

Merged
merged 6 commits into from
Jun 26, 2020
Merged

cmd ref: more updates on new dag command #1496

merged 6 commits into from
Jun 26, 2020

Conversation

jorgeorpinel
Copy link
Contributor

Continuation of #1383

@jorgeorpinel jorgeorpinel requested a review from efiop June 24, 2020 08:55
@shcheklein shcheklein temporarily deployed to dvc-landing-cmd-dag-qa6viqxezv June 24, 2020 08:55 Inactive
specified stage. By default it lists
[DVC-files](/doc/user-guide/dvc-files-and-directories).
Display connected [stages](/doc/command-reference/run) in the pipelines that
contains them.

This comment was marked as resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, is that contain them really necessary? Stages belong to pipelines by definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but there could be more than one pipeline right? This command shows the one that contains the target stage (if a target is provided).

Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Jun 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yeah this could be simplifies as much as just "Display pipeline(s)."

The help output reads Visualize DVC project DAG. though. We should try to have these descriptions match. Isn't "pipeline" still the preferred term?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there could be more than one pipeline.

DAG and pipeline(s) are not really conflicting, not sure there should be a prefered term necessarily.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From multiple experiences with key terminology, it's best to avoid synonyms. They can cause confusion and make docs harder to maintain. Unfortunately I don't see us moving away from "pipeline" and the command is now called dag so these will have to coexist but still I would prefer "pipelines" as much as possible (and some links to "DAG" concept [Wikipedia] and dvc dag of course).

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-cmd-dag-qa6viqxezv June 24, 2020 17:45 Inactive
@jorgeorpinel jorgeorpinel requested a review from shcheklein June 24, 2020 17:49
@jorgeorpinel jorgeorpinel requested a review from shcheklein June 25, 2020 18:45
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-cmd-dag-qa6viqxezv June 25, 2020 19:08 Inactive
[metrics](/doc/command-reference/metrics).
data, and has a final result.

Data processing or ML pipelines typically start a with large raw datasets,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all this text is pretty bad :( let's create a ticket to rewrite it since it's def not a focus of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted to #1500

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-cmd-dag-qa6viqxezv June 26, 2020 01:01 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-cmd-dag-qa6viqxezv June 26, 2020 02:40 Inactive
@shcheklein shcheklein merged commit b87679a into master Jun 26, 2020
@shcheklein shcheklein deleted the cmd/dag branch June 30, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants