-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd ref: more updates on new dag command #1496
Conversation
specified stage. By default it lists | ||
[DVC-files](/doc/user-guide/dvc-files-and-directories). | ||
Display connected [stages](/doc/command-reference/run) in the pipelines that | ||
contains them. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, is that contain them
really necessary? Stages belong to pipelines by definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but there could be more than one pipeline right? This command shows the one that contains the target stage (if a target is provided).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yeah this could be simplifies as much as just "Display pipeline(s)."
The help output reads Visualize DVC project DAG.
though. We should try to have these descriptions match. Isn't "pipeline" still the preferred term?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there could be more than one pipeline.
DAG and pipeline(s) are not really conflicting, not sure there should be a prefered term necessarily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From multiple experiences with key terminology, it's best to avoid synonyms. They can cause confusion and make docs harder to maintain. Unfortunately I don't see us moving away from "pipeline" and the command is now called dag
so these will have to coexist but still I would prefer "pipelines" as much as possible (and some links to "DAG" concept [Wikipedia] and dvc dag
of course).
Co-authored-by: Ruslan Kuprieiev <[email protected]>
[metrics](/doc/command-reference/metrics). | ||
data, and has a final result. | ||
|
||
Data processing or ML pipelines typically start a with large raw datasets, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all this text is pretty bad :( let's create a ticket to rewrite it since it's def not a focus of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracted to #1500
Continuation of #1383