Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document --backup import behaviour #1788

Closed

Conversation

charlesbaynham
Copy link

@charlesbaynham charlesbaynham commented Sep 20, 2020

Documenting the changes in iterative/dvc#4581

REVIEW UPDATE: Jump to #1788 (comment)

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this! Great start. Needs some clarification and expansion still. Oh, and formatting! Please see https://dvc.org/doc/user-guide/contributing/docs#development-environment

Comment on lines 57 to 63
## Checkout failed with `store: false` outputs {#checkout-no-store}

DVC is unable to checkout any output that is not present in the
<abbr>cache</abbr>.This can usually be solved by fetching from
[import storage](/doc/command-reference/remote). However, If `store: false`
is used in a `.dvc` file, `dvc pull` and `dvc fetch` won't attempt to retrieve the
data from a DVC remote.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to update this title, anchor, and description a little per iterative/dvc#4581 (review)...

is used in a `.dvc` file, `dvc pull` and `dvc fetch` won't attempt to retrieve the
data from a DVC remote.

To solve this, you must provide the file locally.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to suggest more elaborate possible solution(s) that will cover most of the cases? Not sure what the options are but off the top of my head: push the data from the original repo; remove store: false and try fetch/pull again; re-import; what else? If you can just write them here I'll copy edit it as needed. Thanks!

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need another round of updates but almost there. Maybe let's wait until the core PR is finalized too? Oh and it needs merge of master branch (solve conflicts) 😅

@jorgeorpinel jorgeorpinel added the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Oct 16, 2020
Comment on lines +74 to +78
- `store`: Whether this file or directory can be
[pushed](/doc/command-reference/push) and
[pulled](/doc/command-reference/pull) to/from
[remote storage](/doc/command-reference/remote) (`true` by default for
all outputs except for imports, where it is `false` by default). See
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for imports

Per #1865 (comment) this isn't the only exception. External outputs are also never stored remotely (since they are already in an external cache).

@jorgeorpinel
Copy link
Contributor

Closing this as stale. We can reopen when/if the core PR gets merged. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌛ status: wait-core-merge Waiting for related product PR merge/release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants