-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
horizontal bar plot docs #3964
Merged
Merged
horizontal bar plot docs #3964
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -279,6 +279,9 @@ DVC has the following built-in plot templates: | |
[example](/doc/command-reference/plots/show#example-confusion-matrix) | ||
- `confusion_normalized` - confusion matrix with values normalized to <0, 1> | ||
range | ||
- `bar_horizontal` - horizontal bar plot, see | ||
[example](/doc/command-reference/plots/show#example-horizontal-bar-plot) | ||
- `bar_horizontal_sorted` - horizontal bar plot sorted by bar size | ||
Comment on lines
+282
to
+284
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor: I think "bar chart" is much more widely used. But surprisingly (for me) term "bar plot" is not insignificant out there 🤷🏼 |
||
|
||
Note that in the case of CSV/TSV metrics files, column names from the table | ||
header (first row) are equivalent to field names. | ||
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tibor-mach something funny is happening here 🤔 Did you run the pre-commit hook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't because the
.pre-commit-config.yaml
seems to be missing in the repo. There is a.pre-commit-hooks.yaml
file but it is not a valid config...so I am bit confused about how I can run it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in this case it's installed if you run
yarn
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a bit more details - https://dvc.org/doc/contributing/docs#development-environment, but you don't need to run everything. And we are figuring out how to simplify the workflow for the external contributors. We had an external tool (Restyled) that was taking care of running linters and creating a fixed PR on top of a contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did run
yarn
though. I set up a locally hosted version of the website withyarn develop
and had it opened as I was editing the code.I now also ran all the liters etc. manually. Everything seems to be fine. Building it also works fine...
I do get the following warning and error when I run
yarn develop
though. Not sure if this might have something to do with the problem here (I am not exactly sure what the problem is as it works on my machine :-) ... Perhaps a devcontainer would help here ... )