Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Started - Condensing landing page #4502

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

omesser
Copy link
Contributor

@omesser omesser commented Apr 28, 2023

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please choose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Followup to #4460

Main changes

  • get-started index shorter, link only to first chapter of each trail
  • each trail gets an index navigation page for powerful navigation, even though going from top page, you may never see it

@omesser omesser requested a review from a team as a code owner April 28, 2023 00:25
@omesser omesser requested review from dberenbaum and daavoo April 28, 2023 00:25
@omesser omesser changed the title Get Started - condensing landing page Get Started - Condensing landing page Apr 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023

Link Check Report

There were no links to check!

Comment on lines +42 to +43
Pick a page from the list above, the left-side navigation bar, or just click
`NEXT` below!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth referring back to https://dvc.org/doc/start#get-started-with-dvc somewhere in these pages? No strong opinion, so leaving it up to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion as well, why not :) ! I'll add 👍

Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @omesser, LGTM!

@omesser omesser temporarily deployed to dvc-org-get-started-con-4lv9fd April 28, 2023 16:53 Inactive
@omesser omesser merged commit 846752a into main Apr 28, 2023
@omesser omesser deleted the get_started_condense_index branch April 28, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants