Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(website): testing download link check #4550

Closed
wants to merge 1 commit into from

Conversation

shcheklein
Copy link
Member

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please choose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@shcheklein shcheklein requested a review from a team as a code owner May 18, 2023 16:16
@shcheklein
Copy link
Member Author

@yathomasi getting a broken restyle check - anything that you are aware of / or see from the top of your head?

@yathomasi
Copy link
Contributor

yathomasi commented May 18, 2023

@shcheklein

  • It had happened before as well.
  • Problem with Restyler Job #3056822 restyled-io/restyler#204
  • The error is Error: Cannot find module '@dvcorg/gatsby-theme-iterative/tailwind.config'
  • According to them, they don't download the package and only include them if it was a standard package or want us to use a custom Restyler Image. source
  • It should be okay to ignore it for now; if we want to deploy, we should manually trigger it. Let me trigger the build on Heroku.

@yathomasi yathomasi temporarily deployed to dvc-org-test-download-l-6cjkfl May 18, 2023 16:40 Inactive
@github-actions
Copy link
Contributor

Link Check Report

There were no links to check!

@shcheklein
Copy link
Member Author

It should be okay to ignore it for now; if we want to deploy, we should manually trigger it. Let me trigger the build on Heroku.

thanks @yathomasi ... will it be fixed by itself? not sure I understand what is the plan for this

@yathomasi
Copy link
Contributor

@shcheklein I meant to ignore for now so that you could test the download link check functionality.

I created a issue for that: #4553. I am not sure of the priority as it will be working for content(markdown files). Anyway, solution looks straight forward it just need us to create a docker image and host ourselves.

@shcheklein shcheklein closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants