-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repro: enforce targets (and update desc) when -R is present? [qa] #4292
Comments
This comment has been minimized.
This comment has been minimized.
An alternative to this, as I discussed with @efiop, is to make -R accept an argument, instead of relying on |
|
True, you could combine the args like P/s I wonder what happens if you supply a path to a dvc.yaml file as target along with a |
Yes, it is. So, strangely, UPDATE: Added quick note about this in iterative/dvc.org@d30bc63. |
* cmd: review repro examples per #1572 (comment) * cmd: fic tyupo in get-url * cmd: updates to repro per #1572 (review) * cmd: rewrite repro -P desc rel #1572 (review) * cmd: simplified and generalize repro targets desc and DVC file mention per #1572 (comment) and #1572 (comment) * cmd: minor update for repro desc wording per #1572 (comment) * term: don't use "synchronize" in the context of checkout * cmd: rewrite Downstream example and added info for sequential execution of stages * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * cmd: Updated Downstream example * Update content/docs/command-reference/repro.md * repro: Updated Downstream example * Update content/docs/command-reference/repro.md * cmd: updated last para for the description of --downstream and improved formatting * cmd: review language of init --subdir * term: revuew usage of "granular", esp. around init --subdir * repro.md: updated Downstream example * cmd: improve init --subdir explanation * cmd: add info about nested subrepos to init * cmd: fix -P option desc. per #1615 (review) * cmd: improve explanation on how --subdir affects commands per #1615 (review) * cmd: simplify nested structures explanation in init per #1615 (comment) * guide: add note aboud `cp` not being a download in external deps per #1643 (review) * cmd: add note about what --cwd means to repro per iterative/dvc#4292 (comment) * guide: nvmd! removing that note in external deps per 42b670f#r41087633 * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * cmd: more small updates to init * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * Restyled by prettier * cmd: rewrap metrics diff usage paragraph * term: remove "just" from -j desc in 3 refs per eda27fc * cmd: add command examples to init --subdir use cases per #1615 * cmd: explain nested repo and projects of all kinds outside of --subdir per #1615 (review) * cmd: remove bold names to nested and not-nested structure examples in init --subdir per #1615 (review) * cmd: standardize --jobs option in all refs per #1615 (review) et al. * cmd: add speed note to --jobs desc in all refs. per #1615 (review) * cmd: change versioning command example in init per #1615 (review) * cd: change repo comments in init --subdir examples for #1615 (review) * cmd: improve note on DVC submodules a little for #1615 (review) * cmd: better explain why isolation is important in --subdir bullet per #1615 (review) * cmd: split last --subdir cases explicitly as 2 bullets per #1615 (comment) * cmd: remove most notes and code block examples about nesting projects/repos in init per #1615 (review) Co-authored-by: sarthakforwet <[email protected]> Co-authored-by: Restyled.io <[email protected]>
* cmd: review repro examples per #1572 (comment) * cmd: fic tyupo in get-url * cmd: updates to repro per #1572 (review) * cmd: rewrite repro -P desc rel #1572 (review) * cmd: simplified and generalize repro targets desc and DVC file mention per #1572 (comment) and #1572 (comment) * cmd: minor update for repro desc wording per #1572 (comment) * term: don't use "synchronize" in the context of checkout * cmd: rewrite Downstream example and added info for sequential execution of stages * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * cmd: Updated Downstream example * Update content/docs/command-reference/repro.md * repro: Updated Downstream example * Update content/docs/command-reference/repro.md * cmd: updated last para for the description of --downstream and improved formatting * cmd: review language of init --subdir * term: revuew usage of "granular", esp. around init --subdir * repro.md: updated Downstream example * cmd: improve init --subdir explanation * cmd: add info about nested subrepos to init * cmd: fix -P option desc. per #1615 (review) * cmd: improve explanation on how --subdir affects commands per #1615 (review) * cmd: simplify nested structures explanation in init per #1615 (comment) * guide: add note aboud `cp` not being a download in external deps per #1643 (review) * cmd: add note about what --cwd means to repro per iterative/dvc#4292 (comment) * guide: nvmd! removing that note in external deps per 42b670f#r41087633 * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * cmd: more small updates to init * Update content/docs/command-reference/repro.md * Update content/docs/command-reference/repro.md * Restyled by prettier * cmd: rewrap metrics diff usage paragraph * term: remove "just" from -j desc in 3 refs per eda27fc * cmd: add command examples to init --subdir use cases per #1615 * cmd: explain nested repo and projects of all kinds outside of --subdir per #1615 (review) * cmd: remove bold names to nested and not-nested structure examples in init --subdir per #1615 (review) * cmd: standardize --jobs option in all refs per #1615 (review) et al. * cmd: add speed note to --jobs desc in all refs. per #1615 (review) * cmd: change versioning command example in init per #1615 (review) * cd: change repo comments in init --subdir examples for #1615 (review) * cmd: improve note on DVC submodules a little for #1615 (review) * cmd: better explain why isolation is important in --subdir bullet per #1615 (review) * cmd: split last --subdir cases explicitly as 2 bullets per #1615 (comment) * cmd: remove most notes and code block examples about nesting projects/repos in init per #1615 (review) * cmd: add basic text about nesting to init * cmd: revert nested block examples back into --subdir per #1661 (review) * cmd: remove new section about nesting to revert more Co-authored-by: sarthakforwet <[email protected]> Co-authored-by: Restyled.io <[email protected]>
The
-R
option ofdvc repro
has no effect when notargets
that are directories are also given. For example,dvc repro -R
is the same as justdvc repro
. For UI and consistency improvement I proposetargets
are enforced when-R
is used, or at least WARN msg is printed otherwise so the user is aware he might be expecting something that's not being done.targets
are given, at least one of them should be an existing directory path, or the above enforcement/warning will happen.THE REMAINING TEXT HAS BEEN EXTRACTED TO #4393 (so stop reading)
Separately (but related), the
targets
param accepted bydvc repro
is described (in its help output) asStages to reproduce. 'dvc.yaml' by default.
This message is confusing as dvc.yaml is not a stage. In docs we're usingStage or .dvc file to reproduce
but that's not correct either because apparently paths to dvc.yaml files are also accepted.Stage or path to dvc.yaml or .dvc file to reproduce
instead?and I'll explain this special case further in the cmd ref. Options.
The text was updated successfully, but these errors were encountered: