Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plots: integration tests for vscode #7549

Closed
pared opened this issue Apr 5, 2022 · 0 comments · Fixed by #7614
Closed

plots: integration tests for vscode #7549

pared opened this issue Apr 5, 2022 · 0 comments · Fixed by #7614
Assignees
@pared
Labels
product: VSCode Integration with VSCode extension testing Related to the tests and the testing infrastructure

Comments

@pared
Copy link
Contributor

pared commented Apr 5, 2022 •
edited
Loading

The --json option for dvc plots subcommands needs integration tests that would serve as a contract between dvc and vscode.

Current use cases:

  • plots with and without some properties - make sure proper JSON is produced
  • are no plots in the repo at all
  • verify that data types for JSON structure are as expected by vscode

cc @mattseddon
Related : iterative/vscode-dvc#1521 iterative/vscode-dvc#1520
@pared pared added testing Related to the tests and the testing infrastructure product: VSCode Integration with VSCode extension labels Apr 5, 2022
@pared pared added this to DVC Apr 5, 2022
@pared pared moved this to Backlog in DVC Apr 5, 2022
@pared pared mentioned this issue Apr 6, 2022
Merged
2 tasks
@pared pared moved this from Backlog to In Progress in DVC Apr 12, 2022
@pared pared self-assigned this Apr 19, 2022
@pared pared mentioned this issue Apr 21, 2022
Merged
2 tasks
@pared pared moved this from In Progress to Review In Progress in DVC Apr 26, 2022
pared added a commit to pared/dvc that referenced this issue Apr 26, 2022
@pared
plots: tests: integration test for vscode
e224f87 
Closes: iterative#7549
pared added a commit to pared/dvc that referenced this issue Apr 26, 2022
@pared
plots: tests: integration tests for studio
d6f52f1 
Related: iterative#7549
Repository owner moved this from Review In Progress to Done in DVC Apr 26, 2022
daavoo pushed a commit that referenced this issue Apr 26, 2022
@pared @daavoo
plots: tests: integration test for vscode
700b648 
Closes: #7549
daavoo pushed a commit that referenced this issue Apr 26, 2022
@pared @daavoo
plots: tests: integration tests for studio
10bcc99 
Related: #7549
This was referenced Apr 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pared pared

Labels
product: VSCode Integration with VSCode extension testing Related to the tests and the testing infrastructure
Projects
No open projects
DVC
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

plots: tests: integration test for empty repo pared/dvc
1 participant
@pared