Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: mark test_get/import as flaky #10148

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Dec 8, 2023

Sometimes seeing those error out in 2.x and early 3.x with:

ERROR: unexpected error - [Errno 95] no more link types left to try out: [Errno 95] Operation not supported

It seems like we've fixed it at some point, but I was not able to quickly find a link. Will update this if I do.

Sometimes seeing those error out in 2.x and early 3.x with:

```
ERROR: unexpected error - [Errno 95] no more link types left to try out: [Errno 95] Operation not supported
```

It seems like we've fixed it at some point, but I was not able to quickly find a link.
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7c898cf) 90.64% compared to head (1c77d4e) 90.38%.

Files Patch % Lines
dvc/testing/benchmarks/cli/commands/test_get.py 0.00% 2 Missing ⚠️
dvc/testing/benchmarks/cli/commands/test_import.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10148      +/-   ##
==========================================
- Coverage   90.64%   90.38%   -0.26%     
==========================================
  Files         496      496              
  Lines       37747    37751       +4     
  Branches     5488     5490       +2     
==========================================
- Hits        34215    34121      -94     
- Misses       2896     2971      +75     
- Partials      636      659      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop efiop merged commit 1d47b03 into iterative:main Dec 8, 2023
20 of 21 checks passed
@efiop efiop added maintenance skip-changelog Skips changelog labels Dec 8, 2023
@efiop
Copy link
Contributor Author

efiop commented Dec 8, 2023

Thanks to @skshetry for finding it #9512 1d47b03#commitcomment-134529297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant