Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import: fix broken progressbar when importing folder #10678

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

petrchmelar
Copy link
Contributor

@petrchmelar petrchmelar commented Jan 28, 2025

Add child progress bar to dvc fs to report directory import progress correctly.

Fixes #10677

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

dvc/fs/dvc.py Outdated Show resolved Hide resolved
Add child progress bar to dvc fs to report directory import progress correctly.

Fixes iterative#10677
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 91.07%. Comparing base (2431ec6) to head (e8a680d).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10678      +/-   ##
==========================================
+ Coverage   90.68%   91.07%   +0.38%     
==========================================
  Files         504      504              
  Lines       39795    39930     +135     
  Branches     3141     3157      +16     
==========================================
+ Hits        36087    36365     +278     
+ Misses       3042     2938     -104     
+ Partials      666      627      -39     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@skshetry skshetry merged commit da1e0b5 into iterative:main Jan 31, 2025
41 checks passed
@skshetry
Copy link
Member

Thank you, @petrchmelar for the contributions. I made one minor adjustment to your PR on how callback.relative_update() gets called.

I also found a small bug that was fixed in iterative/dvc-data#596.
Benchmark showed a small change but nothing major for get/import.

Single vs multiple progress bars can be tackled separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc import: breaks progress bar when importing folders
3 participants