Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize dvcignore #4242

Merged
merged 9 commits into from
Jul 22, 2020
Merged

Optimize dvcignore #4242

merged 9 commits into from
Jul 22, 2020

Conversation

karajan1001
Copy link
Contributor

@karajan1001 karajan1001 commented Jul 19, 2020

optimize #3869

  • ❗ I have followed the Contributing to DVC checklist.

  • 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

1. unit test update
2. two might cause bugs
dvc/repo/__init__.py Outdated Show resolved Hide resolved
@efiop efiop requested a review from pared July 19, 2020 14:57
efiop added a commit to efiop/dvc that referenced this pull request Jul 19, 2020
@efiop
Copy link
Contributor

efiop commented Jul 19, 2020

For the record: that strange bug with the number of calls of file_md5 was caused by #4244 . Please rebase and it will go away 🙂

efiop added a commit that referenced this pull request Jul 19, 2020
dvc/ignore.py Outdated Show resolved Hide resolved
dvc/ignore.py Outdated Show resolved Hide resolved
dvc/ignore.py Outdated Show resolved Hide resolved
@karajan1001
Copy link
Contributor Author

karajan1001 commented Jul 21, 2020

  File "/opt/python/3.8.0/lib/python3.8/threading.py", line 890, in _bootstrap
    self._bootstrap_inner()
  File "/opt/python/3.8.0/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/opt/python/3.8.0/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/mockssh/server.py", line 56, in handle_client
    command = self.command_queues[channel.chanid].get(block=True)
  File "/opt/python/3.8.0/lib/python3.8/queue.py", line 170, in get
    self.not_empty.wait()
  File "/opt/python/3.8.0/lib/python3.8/threading.py", line 302, in wait
    waiter.acquire()

what's this error?

@pared
Copy link
Contributor

pared commented Jul 21, 2020

@karajan1001 when is it showing up? Running tests?

@karajan1001
Copy link
Contributor Author

@pared
In (https://travis-ci.com/github/iterative/dvc/jobs/363240722)
After I fixed some typo error.

@pared
Copy link
Contributor

pared commented Jul 21, 2020

@karajan1001
I restarted the build, seems fine now.

@karajan1001
Copy link
Contributor Author

karajan1001 commented Jul 22, 2020

@pared

Excuse me, how can I restart build myself?
The network is unstable?

E           Exception: Command docker-compose -f "C:\Users\travis\build\iterative\dvc\tests\docker-compose.yml" -p "pytest-dvc-test" up --build -d returned 1: """Creating network "pytest-dvc-test_default" with the default driver
E           Pulling azurite (mcr.microsoft.com/azure-storage/azurite:3.3.0-preview)...
E           3.3.0-preview: Pulling from azure-storage/azurite
E           image operating system "linux" cannot be used on this platform
E           """.

@pared
Copy link
Contributor

pared commented Jul 22, 2020

@karajan1001
You would need to have access to our builds. @efiop correct me if I am wrong but isn't it restricted to members of the organization?

@efiop
Copy link
Contributor

efiop commented Jul 22, 2020

test failures are unrelated. Thank you! 🙏

@efiop efiop merged commit 67896aa into iterative:master Jul 22, 2020
@karajan1001 karajan1001 deleted the optimize_dvcignore branch July 23, 2020 11:01
@karajan1001 karajan1001 mentioned this pull request Jul 23, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants