plots: Fix repo with removed plots
#7643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
added
product: VSCode
daavoo
commented
Apr 27, 2022
Comment on lines
-245
to
-246
| call(capsys) | ||
| call(capsys, subcommand="diff") |
There was a problem hiding this comment.
@pared we only checked that this didn't raise an error but not the expected result. Updating to dvc-render 0.0.5 raises an error.
I updated to_json to return an empty list for vega plots to match the image plots behavior.
If this is not the expected return format, we need to remove:
In order to get back to previous behavior. Before iterative/dvc-render#24 , this tests were passing but the returns for vega plots were a vega template without data.
Changes in dvc-render 0.0.5 caused error.
daavoo
force-pushed
the
integration-test-removed-pots
branch
from
2edaf67 to
ec3630d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in dvc-render 0.0.5 caused an error.
In iterative/dvc-render#24 the behavior for get_filled_template changed to return an empty string. Previously it returned a valid dictionary with empty
datafield.Updated
to_jsonlogic indvcto not callget_filled_templateat all if there are nodatapoints.