-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
output: support version ID #8223
Conversation
def changed_meta(self) -> bool: | ||
if self.fs.version_aware and self.meta.version_id: | ||
return self.meta.version_id == self.get_meta().version_id | ||
return False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently unused but will be needed for updating imports
4064bb6
to
a124f08
Compare
2e97e3c
to
64d1ed8
Compare
After discussion with @efiop we concluded that
This means that these two cases in a .dvc file are not the same thing:
In the first case, I am tracking the explicit path For calls like In the second case, I am tracking the explicit path For calls like @dberenbaum this seems like something which will not be obvious to users at all but we will eventually have to document/explain it, please take a look and make sure you're on the same page for now |
64d1ed8
to
7779388
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pmrowla ! π
7779388
to
d8919d2
Compare
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. π
related to #8164
This PR does not address import behavior. When using
dvc import-url azure://container/file?versionid=1234
, the pre-existing behavior will still occur, so the resulting import will be permanently pinned toazure://container/file?versionid=1234
.dvc update
will not check for a new version ofazure://container/file
.The only import related change is that the version_id will be captured in the
.dvc
file like:(whereas the old .dvc file would just contain
path: azure://container/dir/file?versionid=2022-08-09T06:33:06.7654238Z
and noversion_id
field)