Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cml: misc workflow updates #12

Merged
merged 3 commits into from
Apr 13, 2022
Merged

cml: misc workflow updates #12

merged 3 commits into from
Apr 13, 2022

Conversation

casperdcl
Copy link
Contributor

No description provided.

@casperdcl casperdcl marked this pull request as ready for review April 11, 2022 17:36
.github/workflows/cml-with-dvc.yaml Show resolved Hide resolved
Comment on lines +44 to 46
# should this be `dvc exp run/repro`?
python get_data.py
python train.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't defined a pipeline in DVC, so I don't think this would work out of the box. In this guide, I'm so far only using the data versioning capability of DVC. Might be worth expanding upon it, but that would also blow up the scope of the blogpost. I think I'll settle for a "next up" in the conclusions.

@casperdcl casperdcl requested a review from RCdeWit April 12, 2022 21:06
@casperdcl casperdcl changed the title cml: add missing node dep cml: misc workflow updates Apr 12, 2022
@RCdeWit RCdeWit merged commit 8b16f31 into iterative:main Apr 13, 2022
@casperdcl casperdcl deleted the patch-1 branch May 10, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants