Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for apt to finish #621

Merged
merged 9 commits into from
Jul 6, 2022
Merged

Wait for apt to finish #621

merged 9 commits into from
Jul 6, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Jul 5, 2022 •
edited
Loading

Closes the real issue on iterative/cml#1086 (comment)

@dacbd
Copy link
Contributor

dacbd commented Jul 5, 2022

update golden refs for tests?

@0x2b3bfa0 0x2b3bfa0 requested a review from dacbd July 5, 2022 19:28
@0x2b3bfa0
Copy link
Member Author

🙈 ❗

@0x2b3bfa0 0x2b3bfa0 self-assigned this Jul 5, 2022
@0x2b3bfa0 0x2b3bfa0 added machine-image resource-runner iterative_runner TF resource resource-machine iterative_machine TF resource labels Jul 5, 2022
dacbd
dacbd suggested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not have the intended effect. gets stuck in a sleep loop.
my quick test shows that file (/var/lib/dpkg/lock) as always present but we probably want something more like lsof /var/lib/dpkg/lock

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Jul 5, 2022 •
edited
Loading

Major blunder. 🤦🏼‍♂️ It uses a fnctl lock and I didn't even know.

@0x2b3bfa0 0x2b3bfa0 requested a review from dacbd July 5, 2022 22:06
dacbd
dacbd suggested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not having the desired effect, caught in a sleep loop.

● cml.service
     Loaded: loaded (/etc/systemd/system/cml.service; enabled; vendor preset: enabled)
     Active: active (running) since Tue 2022-07-05 22:17:24 UTC; 7min ago
   Main PID: 14984 (cml.sh)
      Tasks: 2 (limit: 19190)
     Memory: 1.6M
     CGroup: /system.slice/cml.service
             ├─14984 /bin/sh /usr/bin/cml.sh
             └─19491 sleep 1

Jul 05 22:17:24 cml-qoyvzp8y43 systemd[1]: Started cml.service.

# with no apt process running
sudo lsof /var/lib/dpkg/lock
echo $?
# 1

# with apt process running
sudo lsof /var/lib/dpkg/lock
echo $?
# 0

I believe we want to drop the !

iterative/testdata/script_template_cloud_gcp.golden Outdated Show resolved Hide resolved
@0x2b3bfa0 @dacbd
🥶
4afa3dd 
Co-authored-by: Daniel Barnes <[email protected]>
@0x2b3bfa0 0x2b3bfa0 requested a review from dacbd July 5, 2022 22:34
dacbd
dacbd approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps a patch release?

@0x2b3bfa0 0x2b3bfa0 merged commit 9da1179 into master Jul 6, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the await-last-unattended-upgrades branch July 6, 2022 10:43
@casperdcl casperdcl mentioned this pull request Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacbd dacbd dacbd approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
machine-image resource-machine iterative_machine TF resource resource-runner iterative_runner TF resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x2b3bfa0 @dacbd