Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus experiments webview whenever user chooses to "run experiment" or "show experiments" #158

Closed
mattseddon opened this issue Mar 15, 2021 · 5 comments
Labels
A: experiments Area: experiments table webview and everything related bug Something isn't working 🏠 housekeeping

Comments

@mattseddon
Copy link
Member

We need to make sure that if a user (through any UI path) runs an experiment or shows the experiments webview that the webview is focused (shown).

Initial load of the webview works, subsequent attempts to focus it do not.

See below for a screen recording of the current UX:

Screen.Recording.2021-03-15.at.4.45.50.pm.mov
@mattseddon
Copy link
Member Author

Relates to #156

@mattseddon mattseddon added bug Something isn't working A: experiments Area: experiments table webview and everything related labels Mar 15, 2021
itsmesean added a commit that referenced this issue Mar 15, 2021
@shcheklein
Copy link
Member

It seems that if we can we should be running the experiments panel in a split mode by default.

@mattseddon
Copy link
Member Author

@shcheklein I changed this because when we split the screen and open the view on the RHS there isn't enough room to render the table, I have a fairly wide monitor and this is what it looks like when we open in Two:

image

If we were going to persist with opening in a split view would we change the design of the table? Perhaps swap columns and rows?

The current approach also doesn't take into account that some people will already have > 1 editor group set. We will currently always open the panel in the second group. Example with three groups:

image

@itsmesean
Copy link

If we rework the webview to be responsive, then we don't need to worry about how big the window is. We could conditionally render the location/size of the webview based on the users current layout, and place the webview in an appropriate location that doesn't completely throw away the current layout the user has, while saving the original layout so we can revert back when the user closes the webview.

This can be done by a using various commands that split/resize views and then inject the webview once everything is just right.

@rogermparent
Copy link
Contributor

Seems like an old Issue that's since been solved, wince the described behavior happens now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related bug Something isn't working 🏠 housekeeping
Projects
None yet
Development

No branches or pull requests

4 participants