-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus experiments webview whenever user chooses to "run experiment" or "show experiments" #158
Comments
Relates to #156 |
It seems that if we can we should be running the experiments panel in a split mode by default. |
@shcheklein I changed this because when we split the screen and open the view on the RHS there isn't enough room to render the table, I have a fairly wide monitor and this is what it looks like when we open in If we were going to persist with opening in a split view would we change the design of the table? Perhaps swap columns and rows? The current approach also doesn't take into account that some people will already have > 1 editor group set. We will currently always open the panel in the second group. Example with three groups: |
If we rework the webview to be responsive, then we don't need to worry about how big the window is. We could conditionally render the location/size of the webview based on the users current layout, and place the webview in an appropriate location that doesn't completely throw away the current layout the user has, while saving the original layout so we can revert back when the user closes the webview. This can be done by a using various commands that split/resize views and then inject the webview once everything is just right. |
Seems like an old Issue that's since been solved, wince the described behavior happens now. |
We need to make sure that if a user (through any UI path) runs an experiment or shows the experiments webview that the webview is focused (shown).
Initial load of the webview works, subsequent attempts to focus it do not.
See below for a screen recording of the current UX:
Screen.Recording.2021-03-15.at.4.45.50.pm.mov
The text was updated successfully, but these errors were encountered: