Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint-staged breaks markdown links in block quotes #1881

Closed
jorgeorpinel opened this issue Jun 13, 2022 · 5 comments
Closed

lint-staged breaks markdown links in block quotes #1881

jorgeorpinel opened this issue Jun 13, 2022 · 5 comments

Comments

@jorgeorpinel
Copy link
Contributor

Yep the linter in the Git hook keeps breaking it. Could use some help fixing that up. See 9e6218a

Originally posted by @jorgeorpinel in #1816 (comment)

@jorgeorpinel jorgeorpinel changed the title lint-staged breaks markdown links in code blocks lint-staged breaks markdown links in code blocks Jun 13, 2022
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jun 13, 2022

Ideally it should use the same linter as the PR checks, which is yarn run lint = yarn turbo run lint --parallel. But auto-fixing, and only on staged files

@jorgeorpinel jorgeorpinel changed the title lint-staged breaks markdown links in code blocks lint-staged breaks markdown links in quotes Jun 13, 2022
@jorgeorpinel jorgeorpinel changed the title lint-staged breaks markdown links in quotes lint-staged breaks markdown links in block quotes Jun 13, 2022
@sroy3
Copy link
Contributor

sroy3 commented Jun 13, 2022

Not sure if we can make an exception for this particular line break in our config. Can you try adding <!-- prettier-ignore --> before the line? It seems to work on my side.

@mattseddon
Copy link
Member

Fix demonstrated in #1875.

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jun 14, 2022

Thanks for the workaround. But what about local vs CI checks consistency? I guess it's not critical for md files but this could affect the code base development too.

Ideally it should use the same linter as the PR checks, which is yarn run lint = yarn turbo run lint --parallel. But auto-fixing, and only on staged files

@mattseddon
Copy link
Member

Thanks for the workaround. But what about local vs CI checks consistency? I guess it's not critical for md files but this could affect the code base development too.

CI uses the same config so will exclude that line as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants