Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview banner #1875

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Preview banner #1875

merged 3 commits into from
Jun 14, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jun 11, 2022

Needs repo to be open-source

image

See comments for redo with less badges.

@mattseddon mattseddon added the product PR that affects product label Jun 11, 2022
@mattseddon mattseddon self-assigned this Jun 11, 2022
@mattseddon mattseddon changed the base branch from main to add-badges June 11, 2022 04:52
README.md Outdated Show resolved Hide resolved
@shcheklein
Copy link
Member

Looks like we have too many badges. Let's keep one for tests please, fit them into two lines.

@mattseddon
Copy link
Member Author

Redone:

image

@@ -50,6 +52,7 @@ databases are required.
2. Install this extension in VS Code.
3. Follow the **Get Started** page that pops up!

<!-- prettier-ignore -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this what so we can have:

💡 Feel free to try our [example DVC project] first! Opening it [with Github Codespaces] will include this extension automatically.

(all on one line or break after ])

@mattseddon mattseddon requested a review from shcheklein June 14, 2022 01:50
@mattseddon mattseddon marked this pull request as ready for review June 14, 2022 01:51
@mattseddon
Copy link
Member Author

mattseddon commented Jun 14, 2022

@jorgeorpinel we can merge directly from this branch to readme (instead of merging add-badges first) if you like and collect all of the commits into a single squashed one. I'm not precious whatever works for you.

Base automatically changed from add-badges to readme June 14, 2022 02:01
@jorgeorpinel jorgeorpinel merged commit 4ca6219 into readme Jun 14, 2022
@jorgeorpinel jorgeorpinel deleted the preview-banner branch June 14, 2022 02:10
@jorgeorpinel
Copy link
Contributor

precious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants