Rearrange test fixtures #1001
Merged
Rearrange test fixtures #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Nov 4, 2021
| @@ -104,8 +104,8 @@ suite('Experiments Filter By Tree Test Suite', () => { | |||
|
|
|||
| expect(messageSpy).to.be.calledWith({ | |||
| data: { | |||
| changes: complexChangesData, | |||
| columns: complexColumnData, | |||
| changes: workspaceChangesFixture, | |||
There was a problem hiding this comment.
[I] Rename changes to workspaceChanges as housekeeping exercise
mattseddon
force-pushed
the
rename-test-fixtures
branch
from
62010d6 to
f3392c0
Compare
|
Code Climate has analyzed commit f3392c0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.2% (0.0% change). View more on Code Climate. |
This was referenced Nov 5, 2021
rogermparent
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/5 master <- this <- #995 <- #996 <- #998 <- #999
This PR moves all of the
exp showbased test fixtures into anexpShowfolder and the solitaryplotsShowfixture into another one.IMO this split will make where the data comes from more obvious and enable the reader to (at a glance) know they are working with a fixture.